Fix accepted types for fputcsv fields parameter #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Feb 17, 2021
| public function testPutCsvWithStringable(): void | ||
| { | ||
| if (PHP_VERSION_ID < 80000) { | ||
| $this->markTestSkipped('Test skipped under 8.0'); |
There was a problem hiding this comment.
I read "under 8.0" as "when running 8.0". Something like "before" or "on lower version than" would be nicer.
There was a problem hiding this comment.
Added a better message.
| @@ -0,0 +1,17 @@ | |||
| <?php declare(strict_types = 1); | |||
|
|
|||
| class StringablePerson implements \Stringable { | |||
There was a problem hiding this comment.
Please don't put these test files in global namespace. Some namespace like "namespace FputcsvPhp8" would work.
| @@ -0,0 +1,38 @@ | |||
| <?php declare(strict_types=1); | |||
|
|
|||
| class Person | |||
There was a problem hiding this comment.
Please don't put these test files in global namespace. Some namespace like "namespace FputcsvTest" would work.
ondrejmirtes
approved these changes
Feb 18, 2021
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly fix type for
fputcsvfunction parameter$fields. Fix attempt made in #448