More precise checkdate() signature #714
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Oct 15, 2021
| 'chdb_create' => ['bool', 'pathname'=>'string', 'data'=>'array'], | ||
| 'chdir' => ['bool', 'directory'=>'string'], | ||
| 'checkdate' => ['bool', 'month'=>'int', 'day'=>'int', 'year'=>'int'], | ||
| 'checkdate' => ['bool', 'month'=>'int<1, 12>', 'day'=>'int<1, 31>', 'year'=>'int<1, 32767>'], |
There was a problem hiding this comment.
actually I am not 100% sure whether month and day upper-bounds are a good thing.
the function itself accepts values which are higher without a error, but always returns false then.
maybe the month/day interval should not have an upper bound?
in contrast the year interval is defined in the php-src manual as
The year is between 1 and 32767 inclusive.
see https://www.php.net/manual/en/function.checkdate.php
we could create a rule for checkdate' parameters but I don't think its worth it.
There was a problem hiding this comment.
Hi, even a wrong year just returns false so this PR isn't a good fit for PHPStan: https://3v4l.org/AAtDi
Thanks anyway :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.