DateFunctionReturnTypeExtension: support more precise single-char date-formats #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Oct 19, 2021
|
Doing a bit more research I realized I should rework this to return unions of strings instead |
|
Done - Test failure seems unrelated |
|
Yeah, let's try this, but I worry that I'll have to revert it for some reason or another :) In that case I'd welcome if it returned at least a non-empty-string. |
|
Thank you! |
|
really like that phpstan with this PR tells me that I have a type-mismatch in this case <3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds Integer-Ranges for the most basicdatesingle-char formats. IMO these are used in the wild rather often, therefore these are worth supporting.as a followup it would also be great to add support for the formats which contains leading zeros, but these cannot be represented user Integer-Range, I think.We might instead use unions for those zero-leading formats which only support a countable number of values though - this should be a separate PR though.