More precise phpdocs in Container-Interface/Classes

[staabm]

No description provided.

[staabm]

the phpdoc change is helpful to make phpstorm (and phpstan) aware of the type beeing returned by getByType.

not sure such a phpdoc change is considered a BC break, as it leads to static-analysis time errors when implemented in downstream code.

[staabm]

phpstan reports

Method PHPStan\DependencyInjection\Nette\NetteContainer::getByType() should return T of object but returns object.

I dont know how to fix that

[ondrejmirtes]

https://phpstan.org/user-guide/stub-files

[staabm]

just added the stub. now I get

Method PHPStan\DependencyInjection\Nette\NetteContainer::getByType() should return T of object but returns T of object.

which seems to be a phpstan bug?

btw: nette-di has newer releases and the latest 3.0.11 has a proper phpdoc for this method

[staabm]

for now I committed a workaround, which no longer requires the stubfile - since I was not able to resolve the error mentioned in the comment above.

I figured the problem regarding "should return T of object but returns T of object." should be solved in a separate PR...?

[ondrejmirtes]

i dislike inline @var when there can be a better solution: https://phpstan.org/writing-php-code/phpdocs-basics#inline-%40var

So I'd like the stub file much more. And this PR is fine, it's called "More precise phpdocs in Container".

[staabm]

ok. I reverted the last 3 commits and we are back at the point

Method PHPStan\DependencyInjection\Nette\NetteContainer::getByType() should return T of object but returns T of object.

[ondrejmirtes]

I forgot there's already an extension for this method: https://github.com/phpstan/phpstan-src/blob/master/build/PHPStan/Build/ServiceLocatorDynamicReturnTypeExtension.php

So we actually don't need a stub, but to fix this extension. I did it on master: 12973cd

So you can rebase your branch, remove the stub and any unrelated changes, and it should be fine, hopefully.

[ondrejmirtes]

Looks like we're hitting some weird bug here.

[ondrejmirtes]

Alright, figured out a working version: 9384783

Thank you.

[staabm]

thank for finishing and sorry for opening such a can of worms, for such a "small change".

but I think its worth it.

[ondrejmirtes]

It is definitely :)