Correct and improve return types for sorting functions #906
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various corrections and improvements to array sorting functions and methods.
natcasesort
,natsort
,uasort
, anduksort
, these are all nullable in PHP 7true
in PHP 8ArrayIterator
,ArrayObject
, andRecursiveArrayIterator
methods which are currently marked asvoid
but always return booleantrue
Adds all of the above to the functionMetadata files to specify that they produce side effectsThe reason for narrowing
bool
totrue
is to clarify that the return value of these functions cannot be used to determine success or failure, similarly to #850.References: