stream_bucket_new returns an object #968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current official PHP docs for `stream_bucket_new` are at: https://www.php.net/manual/en/function.stream-bucket-new.php `stream_bucket_new` appears to have returned an object for a long time (since PHP 5): https://github.com/php/php-src/blame/90b7bde61507cee1c6b37f153909d72f5b203b8c/ext/standard/user_filters.c#L479 In PHP 8.0 resource candidates, the function stub originally stated that it returned `object|false`: https://github.com/php/php-src/blame/9ef2c5c3035904cfd453ab5c106f7738c6f20e0a/ext/standard/basic_functions.stub.php#L1458 ... but this was later adjusted to state that it returns `object` only: https://github.com/php/php-src/blame/c4334fc616e65962bf2f4253d4a6c14ccaa48981/ext/standard/basic_functions.stub.php#L2021 I originally reported this here: phpstan/phpstan#6027
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current official PHP docs for
stream_bucket_neware at: https://www.php.net/manual/en/function.stream-bucket-new.phpstream_bucket_newappears to have returned an object for a long time (since PHP 5): https://github.com/php/php-src/blame/90b7bde61507cee1c6b37f153909d72f5b203b8c/ext/standard/user_filters.c#L479In PHP 8.0 resource candidates, the function stub originally stated that it returned
object|false: https://github.com/php/php-src/blame/9ef2c5c3035904cfd453ab5c106f7738c6f20e0a/ext/standard/basic_functions.stub.php#L1458... but this was later adjusted to state that it returns
objectonly: https://github.com/php/php-src/blame/c4334fc616e65962bf2f4253d4a6c14ccaa48981/ext/standard/basic_functions.stub.php#L2021I originally reported this here: phpstan/phpstan#6027