Allow extending a class without calling `parent::__construct`

[GromNaN]

Feature request

Some classes may have an optional constructor, but the strict rules requires the parent constructor to be called (RequireParentConstructCallRule)

We want to make it easy to extend the Symfony\Componant\Console\Command class, having dependencies injected in the constructor, without requiring a call to the parent constructor. We need to keep the Command::__constructor method for backward compatibility for setting the $name property (see symfony/symfony#59564)

Example: https://phpstan.org/r/9c33c972-d1c6-4608-80b7-990cbbfcc0f8

Ideally, a phpdoc annotation on Command::__constructor method would indicate that calling the constructor in child classes is optional.

Did PHPStan help you today? Did it make you happy in any way?

No response

[ondrejmirtes]

I'd accept a PR that wouldn't require calling the constructor in case the constructor is marked as @deprecated.

At the same time we should check that phpstan-strict-rules mark such a call with an error.

[GromNaN]

Thanks for the quick response. I'll work on a PR.

we should check that phpstan-strict-rules mark such a call with an error.

The error is still reported after adding the @deprecated annotation to the parent constructor: https://phpstan.org/r/2e746597-746f-48fa-9255-373b8f58fced

[ondrejmirtes]

I meant:

At the same time we should check that phpstan-deprecation-rules mark such a call with an error.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.