Report for loops overwriting variables from parent scope (a la foreach)

[dktapps]

https://phpstan.org/r/8f361ed5-7e15-4ffc-a6b0-3b5c33a3b419

PhpStorm complains about code like this, because an argument is being overwritten by a loop, which might not be intended behaviour.

I found it strange that overwriting from foreach context is reported, but not from for context.

Is there a reason for this not being reported, or just a missing feature?

[ondrejmirtes]

Can you post an expected output?

[dktapps]

I'd expect an error to be reported from line 7, telling that the for loop is overwriting the var $a.

[ondrejmirtes]

No problem, get inspired: https://github.com/phpstan/phpstan-strict-rules/blob/master/src/Rules/ForeachLoop/OverwriteVariablesWithForeachRule.php

[dktapps]

For loop initial assignment overwrites variable $a seems clear enough, I think.

I could create a PR to implement this if it's desirable.

[ondrejmirtes]

Yes 😊

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.