Skip to content

Conversation

ruudk
Copy link
Contributor

@ruudk ruudk commented Feb 12, 2021

Fixes #130

It took a bit more work than I expected.

I have tested this on my project and it works fine now.

@ruudk
Copy link
Contributor Author

ruudk commented Feb 12, 2021

@bendavies Could you please validate if it works?

Apply this to your composer.json:

    "repositories": [
        {
            "type": "vcs",
            "url": "http://github.com/ruudk/phpstan-symfony"
        }
    ],
    "require-dev": {
        "phpstan/phpstan-symfony": "dev-full-tree-builder"
    }

and then run composer update phpstan/phpstan-symfony

@bendavies
Copy link

seems to have fixed it yes!

@ruudk
Copy link
Contributor Author

ruudk commented Feb 12, 2021

@ondrejmirtes Applied feedback ✅

@ruudk
Copy link
Contributor Author

ruudk commented Feb 12, 2021

I think it can be done even simpler.... let me give it a shot.

@ruudk
Copy link
Contributor Author

ruudk commented Feb 12, 2021

Tested it on my project again, all good.

@bendavies If you can, please give it another run

Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise 👍

@ondrejmirtes
Copy link
Member

Alright, let's test this in the wild. I'm gonna tag a release right away.

@ondrejmirtes ondrejmirtes merged commit cc9d9ac into phpstan:master Feb 13, 2021
@ondrejmirtes
Copy link
Member

Thank you!

@ruudk ruudk deleted the full-tree-builder branch February 13, 2021 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Call to an undefined method Symfony\Component\Config\Definition\Builder\NodeParentInterface::scalarNode()
3 participants