$message from core Exception cannot have type assigned

[kevinpapst]

Bug report

class ApiLimitExceededException extends \Exception
{
    protected $message = 'You have exceeded the 300 API calls per minute.';
}

leads to

Property ApiLimitExceededException::$message has no type specified.

Adding a PHPDoc /** @var string */ leads to

PHPDoc type string of property ApiLimitExceededException::$message is not the same as PHPDoc type mixed of overridden property Exception::$message.

Code snippet that reproduces the problem

https://phpstan.org/r/43e108f0-2a99-41e0-b95e-366132e294f2

Expected output

Currently this can only be silenced with ignoreErrors ('#^Property App\\HttpClient\\Exception\\(.*)\:\:\$message has no type specified.$#')

I'd expect that PHPStan knows that $message from Exception cannot have a type assigned

Did PHPStan help you today? Did it make you happy in any way?

❤️

[ondrejmirtes]

Yeah, this should not report an error: https://phpstan.org/r/00b72938-1cc0-4212-861a-8386df20fde6

[phpstan-bot]

@kevinpapst After the latest push in 2.1.x, PHPStan now reports different result with your code snippet:

@@ @@
-5: Property ApiLimitExceededException::$message has no type specified.
+No errors

[phpstan-bot]

@ondrejmirtes After the latest push in 2.1.x, PHPStan now reports different result with your code snippet:

@@ @@
-6: PHPDoc type string of property ApiLimitExceededException::$message is not the same as PHPDoc type mixed of overridden property Exception::$message.
+No errors

[VincentLanglet]

This is now fixed on PHPStorm side JetBrains/phpstorm-stubs#1774

Is it worth a non regression test to close this @ondrejmirtes ?

[ondrejmirtes]

Yes please, thank you!

[kevinpapst]

One year later I can't remember which project caused the issue 😁 and therefor can't double check.

But thank you all for taking care of it! 🎉