2.1.27 Bug when overriding PHPDoc type of a protected property in a subclass

[jf-m]

Bug report

Hi,

Since 2.1.27 we can't override a protected property in a subclass.
It worked on my project on 2.1.26 and below:

See the example provided

Code snippet that reproduces the problem

https://phpstan.org/r/983f594a-a257-44ea-bcac-917b096ef823

Expected output

I believe it should not report any issue in this code snippet.

Did PHPStan help you today? Did it make you happy in any way?

Big thanks to the maintainer of this awesome project 🍻

[ondrejmirtes]

Please share the mechanics of this magic. How can an array property become stdClass?

[jf-m]

@ondrejmirtes

Haha, well it was just a simple made-up example actually.

In my application it's a bit different: I'm having a base model class with an protected array $attributes that handles all the attributes of the class. Then I'm using _get magic methods to access what's inside $attributes. (a bit like Eloquent Model)

The problem is one of the classes that extends this base model class has an attribute called attributes, which is a Collection.

When I query $model->attributes outside of the class, phpstan now thinks that I'm referring to the protected property where I'm in fact referring to the attributes key inside the attributes protected property (through __get magic method).

[jf-m]

Here's a second more real-life example

https://phpstan.org/r/43b86dc1-73db-456f-aa28-06bc97f142f1

Should have provided this example at first 😅

[ondrejmirtes]

These details matter. In fact I will tighten the behaviour around the first example and it will report "Access to protected property" in the future.

Your 2nd example that includes __get method should actually work as you expect it to.

[ondrejmirtes]

Fixed phpstan/phpstan-src@5772b1a