False positive when a check is done with a boolean variable instead of directly in the if.

[VincentLanglet]

Bug report

Hi @ondrejmirtes,

When a check is done directly in a if, phpstan take it in account.
When a check is done by creating a boolean variable, which can be useful if the same check is needed to be done multiple times and/or if the check is complicated and we like to give a name for it, and using the boolean variable in the if, phpstan does not take it in account.

I created a simple reproducer, but my usecase is using more complex checks.

Code snippet that reproduces the problem

https://phpstan.org/r/7ce7e2a4-cd78-4658-a085-ec1ef75ccbc5

Expected output

I expect the same behavior than
https://phpstan.org/r/9c3d2da1-0db5-4b06-90e0-645bdb9594f3;

Psalm does:
https://psalm.dev/r/86cb84843f

I end up with the following situation:

• If I don't add the check, phpstan is not happy about the null value.
• If I add the check, psalm complains about a RedundantCondition.

Did PHPStan help you today? Did it make you happy in any way?

Yep, I was just fixing 70 issues of level 8.

[ondrejmirtes]

Hi, version with just a variable works (https://phpstan.org/r/2c723e57-46bd-4c18-b3f5-3b603aee199e) so the fix should probably be easy. Here are the dumped types: https://phpstan.org/r/014e6d6a-5265-4e2b-a7da-ed87111dfde3

[LastDragon-ru]

Seems this is the same case?

https://phpstan.org/r/053c6b5b-cdc4-4cb5-8ff6-d5869f10e5a1

[ondrejmirtes]

@LastDragon-ru Your code is a real head scratcher, I can't understand what's going on there so I'm not surprised that PHPStan can't either :) Feel free to use this much clearer version instead: https://phpstan.org/r/58c55a0f-5970-4dad-a304-4dacd8b6fef3

[phpstan-bot]

@LastDragon-ru After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-PHP 8.0 (1 error)
-==========
-
-28: Method Bug\Args::content() should return string but returns SplFileInfo|string.
-
-PHP 7.1 – 7.4 (2 errors)
-==========
-
-15: Method Bug\Args::content() uses native union types but they're supported only on PHP 8.0 and later.
-28: Method Bug\Args::content() should return string but returns SplFileInfo|string.
+-1: Internal error: PHPStan\Rules\Methods\WrongCaseOfInheritedMethodRule::findMethod(): Argument #2 ($classReflection) must be of type PHPStan\Reflection\ClassReflection, null given, called in /var/task/vendor/phpstan/phpstan-strict-rules/src/Rules/Methods/WrongCaseOfInheritedMethodRule.php on line 40
+Run PHPStan with --debug option and post the stack trace to:
+https://github.com/phpstan/phpstan/issues/new?template=Bug_report.md

Full report

Line

Error

-1

Internal error: PHPStan\Rules\Methods\WrongCaseOfInheritedMethodRule::findMethod(): Argument #2 ($classReflection) must be of type PHPStan\Reflection\ClassReflection, null given, called in /var/task/vendor/phpstan/phpstan-strict-rules/src/Rules/Methods/WrongCaseOfInheritedMethodRule.php on line 40Run PHPStan with --debug option and post the stack trace to:https://github.com/phpstan/phpstan/issues/new?template=Bug_report.md

[phpstan-bot]

@ondrejmirtes After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-PHP 8.0
-==========
-
-No errors
-
-PHP 7.1 – 7.4 (1 error)
-==========
-
-15: Method Bug\Args::content() uses native union types but they're supported only on PHP 8.0 and later.
+-1: Internal error: PHPStan\Rules\Methods\WrongCaseOfInheritedMethodRule::findMethod(): Argument #2 ($classReflection) must be of type PHPStan\Reflection\ClassReflection, null given, called in /var/task/vendor/phpstan/phpstan-strict-rules/src/Rules/Methods/WrongCaseOfInheritedMethodRule.php on line 40
+Run PHPStan with --debug option and post the stack trace to:
+https://github.com/phpstan/phpstan/issues/new?template=Bug_report.md

Full report

Line

Error

-1

Internal error: PHPStan\Rules\Methods\WrongCaseOfInheritedMethodRule::findMethod(): Argument #2 ($classReflection) must be of type PHPStan\Reflection\ClassReflection, null given, called in /var/task/vendor/phpstan/phpstan-strict-rules/src/Rules/Methods/WrongCaseOfInheritedMethodRule.php on line 40Run PHPStan with --debug option and post the stack trace to:https://github.com/phpstan/phpstan/issues/new?template=Bug_report.md

[phpstan-bot]

@VincentLanglet After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-12: Method HelloWorld::sayHello() should return HelloWorld but returns HelloWorld|null.
+ 5: Method HelloWorld::getChild() should return HelloWorld|null but return statement is missing.
+ 7: Method HelloWorld::sayHello() should return HelloWorld but return statement is missing.

Full report

Line	Error
5	`Method HelloWorld::getChild() should return HelloWorld
7	Method HelloWorld::sayHello() should return HelloWorld but return statement is missing.

[phpstan-bot]

@VincentLanglet After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-No errors
+5: Method HelloWorld::getChild() should return HelloWorld|null but return statement is missing.
+7: Method HelloWorld::sayHello() should return HelloWorld but return statement is missing.

Full report

Line	Error
5	`Method HelloWorld::getChild() should return HelloWorld
7	Method HelloWorld::sayHello() should return HelloWorld but return statement is missing.

[phpstan-bot]

@ondrejmirtes After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-No errors
+5: Method HelloWorld::getChild() should return HelloWorld|null but return statement is missing.
+7: Method HelloWorld::sayHello() should return HelloWorld but return statement is missing.

Full report

Line	Error
5	`Method HelloWorld::getChild() should return HelloWorld
7	Method HelloWorld::sayHello() should return HelloWorld but return statement is missing.

[phpstan-bot]

@ondrejmirtes After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-11: Dumped type: HelloWorld|null
-14: Dumped type: HelloWorld
+ 5: Method HelloWorld::getChild() should return HelloWorld|null but return statement is missing.
+ 7: Method HelloWorld::sayHello() should return HelloWorld but return statement is missing.

Full report

Line	Error
5	`Method HelloWorld::getChild() should return HelloWorld
7	Method HelloWorld::sayHello() should return HelloWorld but return statement is missing.

[phpstan-bot]

@LastDragon-ru After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
 PHP 8.0 (1 error)
 ==========
 
-28: Method Bug\Args::content() should return string but returns SplFileInfo|string.
+15: Method Bug\Args::content() should return string but return statement is missing.
 
 PHP 7.1 – 7.4 (2 errors)
 ==========
 
-15: Method Bug\Args::content() uses native union types but they're supported only on PHP 8.0 and later.
-28: Method Bug\Args::content() should return string but returns SplFileInfo|string.
+15: Method Bug\Args::content() should return string but return statement is missing.
+15: Method Bug\Args::content() uses native union types but they're supported only on PHP 8.0 and later.

Full report

PHP 8.0 (1 error)

Line	Error
15	Method Bug\Args::content() should return string but return statement is missing.

PHP 7.1 – 7.4 (2 errors)

Line	Error
15	Method Bug\Args::content() should return string but return statement is missing.
15	Method Bug\Args::content() uses native union types but they're supported only on PHP 8.0 and later.

[phpstan-bot]

@ondrejmirtes After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-PHP 8.0
+PHP 8.0 (1 error)
 ==========
 
-No errors
+15: Method Bug\Args::content() should return string but return statement is missing.
 
-PHP 7.1 – 7.4 (1 error)
+PHP 7.1 – 7.4 (2 errors)
 ==========
 
+15: Method Bug\Args::content() should return string but return statement is missing.
 15: Method Bug\Args::content() uses native union types but they're supported only on PHP 8.0 and later.

Full report

PHP 8.0 (1 error)

Line	Error
15	Method Bug\Args::content() should return string but return statement is missing.

PHP 7.1 – 7.4 (2 errors)

Line	Error
15	Method Bug\Args::content() should return string but return statement is missing.
15	Method Bug\Args::content() uses native union types but they're supported only on PHP 8.0 and later.

[VincentLanglet]

@ondrejmirtes I can try to solve this one if you know where I should look at in the code