Constant anotated with @var is resolved as StringType, not ConstantStringType anymore

[janedbal]

Bug report

See snippet, when you remove that var annotation, it properly finds the always-true condition. Imo broken by phpstan/phpstan-src@b932769

Found when upgrading from 0.12.94 to 0.12.96

Code snippet that reproduces the problem

https://phpstan.org/r/b5200efd-e999-4c12-9e7c-9ebc8eb3ee2a

Expected output

Original behaviour

[ondrejmirtes]

I changed the behaviour because of #3530 and also so that static::CONSTANT has type of string and not mixed, but at the same time I also removed type lossy optimization of CONSTANT_SCALAR_UNION_THRESHOLD. Which means that we can afford self::CONSTANT not to look at the PHPDoc and have the precise type of the class constant value.

[ondrejmirtes]

Implemented: phpstan/phpstan-src@5010ef4

[janedbal]

Thank you!

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.