const type inference

[staabm]

Feature request

I think phpstan should have a better idea regarding the type of the constant
https://phpstan.org/r/8c63c869-05c1-4446-9d95-4f017eca7b4c

maybe it should even consider it a literal string, similar to phpstan/phpstan-src#1692 because we are accing it using ::x ?

[ondrejmirtes]

Some time ago I added support for PHPDocs to enforce the type https://phpstan.org/r/d62693f3-e36c-435b-b139-86b59232d2b1

[staabm]

ok.. should it be a string&literal-string in your example then similar to what we did in phpstan/phpstan-src#1692 because we are accing it using ::x ?

[ondrejmirtes]

Nope, you don't need to change anything in PHPStan in order to get that: https://phpstan.org/r/3e28935a-34b0-40ed-89fc-722dd43700af

[staabm]

what I had in mind is, whether a constant read by ::x should automatically be considered a literal, even without manual typing.
https://phpstan.org/r/f7a473de-df21-497e-b8fe-93685a51362c

[ondrejmirtes]

I disagree with that, the expression in there can be pretty complicated, basically everything that's resolved here https://github.com/phpstan/phpstan-src/blob/1.8.x/src/Reflection/InitializerExprTypeResolver.php can be put as a const value.

And it will grow over time, there was an RFC to call any function in there... https://wiki.php.net/rfc/calls_in_constant_expressions

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.