Add DateInterval properties test #80
Conversation
|
Please fix that in |
|
Unfortunately the test in AccessPropertiesRuleTest will always fail because the Broker instance created by AbstractRuleTest does not contain this extension. You need to move it to PhpDefectClassReflectionExtensionTest. |
|
haha, is it that simple? |
|
Yep, reflection of native PHP stuff is not always up to date so I'm already solving a few cases in PHPStan codebase. |
|
@simPod I see you're implementing it :) One tip: You can use multiple |
|
Good to know. Let me see |
| $this->assertTrue($zipArchiveReflection->hasProperty($propertyName)); | ||
| $propertyReflection = $zipArchiveReflection->getProperty($propertyName); | ||
| $this->assertInstanceOf(PhpDefectPropertyReflection::class, $propertyReflection); | ||
| $this->assertSame($zipArchiveReflection, $propertyReflection->getDeclaringClass()); |
There was a problem hiding this comment.
Fix this variable name just to $classReflection
| $propertyReflection = $zipArchiveReflection->getProperty($propertyName); | ||
| $this->assertInstanceOf(PhpDefectPropertyReflection::class, $propertyReflection); | ||
| $this->assertSame($zipArchiveReflection, $propertyReflection->getDeclaringClass()); | ||
| $this->assertSame($typeDescription, $propertyReflection->getType()->describe()); |
There was a problem hiding this comment.
Problem with this line is that when it fails, I have no idea which property is it. Add a third parameter - message with sprintf('%s::$%s', $className, $propertyName) and test how it looks.
|
Really nice, thank you! |
So. I noticed it says that properties of DateInterval are undefined. But did I update the test correctly? Who knows... Also, this PR only includes updated test. Honestly, I have no Idea how to fix it.