This repository was archived by the owner on Dec 6, 2019. It is now read-only.
Global variables can't be used as parameters, they are global already. #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
there is a development branch that already has the fix. pull request #84 |
|
Nice, but being a big issue, that fix should be merged into master also. I'm seeing that you remove the parameter from the function, but you didn't from where is being used. Check my commit. |
|
Oh, nice catch... After your commit is accepted i would recommend sending a fix the the dev branch. |
nabeelio
added a commit
that referenced
this pull request
Oct 10, 2013
Global variables can't be used as parameters, they are global already.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting warning errors with PHP 5.4 and 5.5
Also, blank spaces were removed in those files.