-
Notifications
You must be signed in to change notification settings - Fork 2
Introduce "composer test" script #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for PR! I just wonder why do you want to run this via composer when it could be run directly by |
A few reasons:
It all comes down to simplification. No real gain here other than that. |
I see your point. It's good idea to have it in composer, but I thin it would be better to have "old" travis or use |
What if, across all PHPZone projects, we were to document it in README.md under a "Development" heading? The only way to teach people is to document and use it. |
I'm not sure if it is a good move. This project was created as a tool to make a development easier and it would be awkward if this project would use Composer for development. I think we should be an example to others how PhpZone could be used. Thanks to your opinion to be able to run commands without |
It is no longer needed to gitignore since it never created. It's now in vendor/bin.
@jakubzapletal Agreed... And have it used across all phpzone projects too. |
Composer
scripts
allows running commands throughcomposer
, along with the updatedbin
PATHs. We can use this to run the tests throughphpzone
itself.For some reason, behat is failing for me. Works on Travis though.