Use SetDirty to mark the asset for save #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forelabs
approved these changes
Feb 5, 2025
| } | ||
| UnityEngine.Localization.Locale newLocale = UnityEngine.Localization.Locale.CreateLocale(locale.code); | ||
| AssetDatabase.CreateAsset(newLocale, $"{pathToSave}/{newLocale.ToString()}.asset"); | ||
| AssetDatabase.CreateAsset(newLocale, $"{pathToSave}/{newLocale}.asset"); |
There was a problem hiding this comment.
Can you explain this change? Was it not needed at all?
There was a problem hiding this comment.
no, that's not needed, as string interpolation implicitly does ToString(). VS code gives a lot of these linting hints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phrase provider changes were not persisted upon exiting Unity Editor. This is due to SetDirty, which needs to be set whenever something is altered. Also we need to wait for LocalizationSettings initialization before we display the provider, as it loads the locales available in Unity.