Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readline detection #1956

Merged
merged 2 commits into from
May 17, 2024
Merged

Readline detection #1956

merged 2 commits into from
May 17, 2024

Commits on May 10, 2024

  1. FTL_lua: Properly guard readline 

    Readline support should only be used when we know it is available. Lets
properly use a ifdef guard like we do in `shell.c`.

Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
    @oliv3r
    oliv3r committed May 10, 2024
    Configuration menu
    Copy the full SHA
    7de24a0 View commit details
    Browse the repository at this point in the history

  2. FTL: Avoid hidden HAVE_READLINE define 

    We should set `HAVE_READLINE` based on whether it was actually
detected/found, not via a hidden fixed, as that contains compile errors
when readline is actually not available.

Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
    @oliv3r
    oliv3r committed May 10, 2024
    Configuration menu
    Copy the full SHA
    be3d4cd View commit details
    Browse the repository at this point in the history