Print human-readable timezone information #1981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… this in the log files to not needlessly change for format. Open for discussion Signed-off-by: DL6ER <dl6er@dl6er.de>
DL6ER
changed the title
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1 similar comment
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: DL6ER <dl6er@dl6er.de>
|
Conflicts have been resolved. |
|
I think this is a useful feature which should be used everywhere. v6 will break a lot of existing stuff, I think it's OK to change the log format. (I think to remember we already change the format from v5 to V6 by including message severity...) |
Signed-off-by: DL6ER <dl6er@dl6er.de>
|
@yubiuser The timezone is now always there |
yubiuser
approved these changes
Jun 2, 2024
There was a problem hiding this comment.
2024-06-02 17:17:51.619 [46769M] INFO: Thread housekeeper (1) is idle, terminating it.
2024-06-02 17:17:51.619 [46769M] INFO: Thread DNS client (2) is idle, terminating it.
2024-06-02 17:17:51.619 [46769M] INFO: All threads joined
2024-06-02 17:17:51.623 [46769M] INFO: Stored 1 API session in the database
2024-06-02 17:17:52.820 [46769M] INFO: ########## FTL terminated after 19h 48m 55s (code 0)! ##########
2024-06-02 17:17:53.250 CEST [60185M] INFO: ########## FTL started on nanopi! ##########
2024-06-02 17:17:53.251 CEST [60185M] INFO: FTL branch: new/timezone
2024-06-02 17:17:53.252 CEST [60185M] INFO: FTL version: vDev-14ea246
2024-06-02 17:17:53.252 CEST [60185M] INFO: FTL commit: 14ea246f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Add timezone information in human-readable timestamps.
This change has been triggered by a user seeking help after they had found a mismatch of timestamps between their two Pi-holes. We have been able to track it down to one server using a local timezone and the other one having been set to UTC.
Old
New
Related issue or feature (if applicable): (private communication)
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase)Checklist:
developmentalbranch.