Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve memory leak in setupVars.c #37

Closed
wants to merge 3 commits into from
Closed

Resolve memory leak in setupVars.c #37

wants to merge 3 commits into from

Conversation

stumpylog
Copy link

By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?: 1


Fixes the simpler of the memory leaks. I've never actually done a pull request, so I've probably messed something up.

This template was created based on the work of udemy-dl.

DL6ER and others added 3 commits May 5, 2017 14:06
* FTL v2.6.1 (#29) (#30)

* Add .github/PULL_REQUEST_TEMPLATE.md (#24)

* Add PullApprove settings file (copied from core repo) (#23)

* Don't forget to free linebuffer also when not used (#28)

* Check pointer values to avoid double-free issues (#31)
else
{
free(domain);
return false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong, it is not possible to return here since that would be skipping the for-loop altogether. Since I don't have write permissions on your fork, I'll open a new PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants