Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add powerpc arch #88

Merged
merged 11 commits into from
Jun 19, 2017
Merged

Add powerpc arch #88

merged 11 commits into from
Jun 19, 2017

Conversation

mterron
Copy link
Contributor

@mterron mterron commented Jun 19, 2017

By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?: 1


Add powerpc arch to the build scripts.

@dschaper dschaper changed the base branch from master to development June 19, 2017 02:19
@DL6ER
Copy link
Member

DL6ER commented Jun 19, 2017

Fixes #71

@DL6ER DL6ER merged commit 52e0845 into pi-hole:development Jun 19, 2017
@mterron mterron deleted the patch-1 branch June 19, 2017 20:19
@mterron
Copy link
Contributor Author

mterron commented Jun 19, 2017

Just an observation. The generated binary is significantly larger than the one I got from compiling on GCC 4.9.2. Seem to work alright AFAIK.

root@MyBook-Live:~# file pihole-FTL-powerpc-linux-gnu $(which pihole-FTL)
pihole-FTL-powerpc-linux-gnu: ELF 32-bit MSB shared object, PowerPC or cisco 4500, version 1 (SYSV), dynamically linked, interpreter /lib/ld.so.1, for GNU/Linux 2.6.32, BuildID[sha1]=98a2b550f82ca20d8580ba3c9c0585802a9c0db0, not stripped
/usr/bin/pihole-FTL:          ELF 32-bit MSB shared object, PowerPC or cisco 4500, version 1 (SYSV), dynamically linked, interpreter /lib/ld.so.1, for GNU/Linux 2.6.32, BuildID[sha1]=684983a82263186ef118bea6e1c9738fa8b9b87b, not stripped
root@MyBook-Live:~# ls -lh pihole-FTL-powerpc-linux-gnu $(which pihole-FTL)
-rwxr-xr-x 1 root root 1.4M Jun 20 07:24 pihole-FTL-powerpc-linux-gnu
-rwxr-xr-x 1 root root 383K Jun 14 16:45 /usr/bin/pihole-FTL
root@MyBook-Live:~# gcc --version
gcc (Debian 4.9.2-10) 4.9.2
Copyright (C) 2014 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

@dschaper
Copy link
Member

May be from the debugging symbols that we leave in the binary for gdb to be able to assist with any issues.

@DL6ER Am I vastly incorrect?

@mterron
Copy link
Contributor Author

mterron commented Jun 20, 2017

Ignore that, compiling the same version gives similar results. Seems that between pihole-FTL v2.8.2 and v2.9.2 the binary size grew from ~400kb to ~1.4MB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants