Pi-hole FTL v5.3.3 #998

DL6ER · 2020-12-23T19:50:24Z

New

Immediately resolve host names of clients and upstream destinations Immediately resolve host names of clients and upstream destinations #996
Add UNKNOWN option for REFRESH_HOSTNAME Add UNKNOWN option for REFRESH_HOSTNAME #985
Add lua and luac drop-in support Add "lua" and "luac" drop-in support #968
Show BOOTP server and file strings used by TFTP in dhcp-discover Show BOOTP server and file strings used by TFTP #963

Tweaks

Add DEBUG_EXTRA flag Add DEBUG_EXTRA flag #994
Improve compatibility with old (ancient) kernels ~~Improve compatibility with old (ancient) kernels #984~~ Implement interrupt-safe systemcalls #969
Add more debugging output for domain reloading (on receipt of SIGHUP) Add more debugging output for domain reloading (on receipt of SIGHUP) #970
Implement interrupt-safe systemcalls Implement interrupt-safe systemcalls #969

Fixes

Escape spaces by ~ in domains and hostnames to fix API issues with such names Escape spaces by ~ #997
Fix CNAME query blocking mode Fix CNAME query blocking mode #995
Fix crashing forks when regex structure changed Fix crashing forks when regex structure changed #982
Fix freeing regex pointers to free the global objects Fix freeing regex pointers to free the global objects #971
Fix possible crash in parse_FTLconf() Fix possible crash in parse_FTLconf() #967
Update dnsmasq version to 2.82 Update dnsmasq version to 2.82 #964

Update development from FTL v5.3.2 release

Signed-off-by: DL6ER <dl6er@dl6er.de>

…structure (once compiled) and cannot be kept globally available through shared memory (at least not with any realistic effort) Signed-off-by: DL6ER <dl6er@dl6er.de>

… buffer itself to avoid getline() crashing in some special edge-cases Signed-off-by: DL6ER <dl6er@dl6er.de>

Fix possible crash in parse_FTLconf()

Update dnsmasq version to 2.82

Show BOOTP server and file strings used by TFTP

Signed-off-by: DL6ER <dl6er@dl6er.de>

…ed syscalls/{}.c files Signed-off-by: DL6ER <dl6er@dl6er.de>

Signed-off-by: DL6ER <dl6er@dl6er.de>

Fix development builds

Signed-off-by: DL6ER <dl6er@dl6er.de>

There is a small typo in src/overTime.c. Should read `timestamp` rather than `timestemp`. Signed-off-by: tgates <tim.gates@iress.com>

docs: fix simple typo, timestemp -> timestamp

…the fallocate() macro, we hav to use a modified name fTLallocate() to implement this function Signed-off-by: DL6ER <dl6er@dl6er.de>

…nied) Signed-off-by: DL6ER <dl6er@dl6er.de>

Signed-off-by: DL6ER <dl6er@dl6er.de>

Revert #984

…r AAAA reply when blocking Signed-off-by: DL6ER <dl6er@dl6er.de>

Implement interrupt-safe systemcalls

Signed-off-by: DL6ER <dl6er@dl6er.de>

Add UNKNOWN option for REFRESH_HOSTNAME

…ut only do this when the RESOLVE_NEW_HOSTNAMES event is set Signed-off-by: DL6ER <dl6er@dl6er.de>

Fix CNAME query blocking mode

Immediately resolve host names of clients and upstream destinations

* Add new DEBUG_EXTRA flag used for special (temporary) debugging Signed-off-by: DL6ER <dl6er@dl6er.de>

Signed-off-by: DL6ER <dl6er@dl6er.de>

Escape spaces by ~

DL6ER and others added 30 commits December 2, 2020 23:10

Merge pull request #958 from pi-hole/master

a12f987

Update development from FTL v5.3.2 release

Show BOOTP server and file strings used by TFTP

bffb443

Signed-off-by: DL6ER <dl6er@dl6er.de>

Update dnsmasq version to 2.82

d5c9222

Signed-off-by: DL6ER <dl6er@dl6er.de>

Use fork-private regex substructure because each regex has an opaque …

bedc5ab

…structure (once compiled) and cannot be kept globally available through shared memory (at least not with any realistic effort) Signed-off-by: DL6ER <dl6er@dl6er.de>

We have to explicitly set conflinebuffersize to zero when freeing the…

33860bf

… buffer itself to avoid getline() crashing in some special edge-cases Signed-off-by: DL6ER <dl6er@dl6er.de>

Merge pull request #967 from pi-hole/fix/parse_FTLconfig

c80b3d8

Fix possible crash in parse_FTLconf()

Merge pull request #964 from pi-hole/fix/dnsmasq_version

800d3e8

Update dnsmasq version to 2.82

Merge pull request #963 from pi-hole/tweak/bootp_fields

03843c7

Show BOOTP server and file strings used by TFTP

Rename memory.c -> syscalls.c

7459d82

Signed-off-by: DL6ER <dl6er@dl6er.de>

Factor out syscalls for calloc, free, realloc and strdup into dedicat…

d4deb01

…ed syscalls/{}.c files Signed-off-by: DL6ER <dl6er@dl6er.de>

Add interrupt-safe fprintf() and printf() routines

9537d7d

Signed-off-by: DL6ER <dl6er@dl6er.de>

Add interrupt-safe vfprintf() and vprintf() routines

217f957

Signed-off-by: DL6ER <dl6er@dl6er.de>

Make calloc(), realloc() and strdup() interrupt-safe

44f88e8

Signed-off-by: DL6ER <dl6er@dl6er.de>

Add interrupt-safe write() routine

1a0df27

Signed-off-by: DL6ER <dl6er@dl6er.de>

Add interrupt-safe accept() routine

e23eb12

Signed-off-by: DL6ER <dl6er@dl6er.de>

Avoid redundant error reporting

06396ba

Signed-off-by: DL6ER <dl6er@dl6er.de>

Improve printf(), fprintf(), vprintf(), and vfprintf() error reporting

b00548e

Signed-off-by: DL6ER <dl6er@dl6er.de>

Add interrupt-safe recv() routine

69ec44c

Signed-off-by: DL6ER <dl6er@dl6er.de>

Add interrupt-safe recvfrom() routine

3dfc069

Signed-off-by: DL6ER <dl6er@dl6er.de>

Add interrupt-safe pthread_mutex_lock() routine

2c35038

Signed-off-by: DL6ER <dl6er@dl6er.de>

Add interrupt-safe select() routine

ffdc52a

Signed-off-by: DL6ER <dl6er@dl6er.de>

Add interrupt-safe fopen() routine

67b1a65

Signed-off-by: DL6ER <dl6er@dl6er.de>

Add interrupt-safe sendto() routine

543ea85

Signed-off-by: DL6ER <dl6er@dl6er.de>

Backup and restore errno in real-time signal handler.

d234dad

Signed-off-by: DL6ER <dl6er@dl6er.de>

Add interrupt-safe vsnprintf() routine

d4d4a0b

Signed-off-by: DL6ER <dl6er@dl6er.de>

Add interrupt-safe snprintf() routine

70a4ad1

Signed-off-by: DL6ER <dl6er@dl6er.de>

Add interrupt-safe vsprintf() routine

20fa5ef

Signed-off-by: DL6ER <dl6er@dl6er.de>

Add interrupt-safe sprintf() routine

ab0daeb

Signed-off-by: DL6ER <dl6er@dl6er.de>

Show complete list of args when complaining about unsupported argument

cd7fc84

Signed-off-by: DL6ER <dl6er@dl6er.de>

Adjust test for unknown argument to support the new format

7580a6f

Signed-off-by: DL6ER <dl6er@dl6er.de>

DL6ER and others added 23 commits December 18, 2020 17:41

Merge pull request #986 from pi-hole/fix/development_regex_change

0c1d71d

Fix development builds

Enable extra logging only when DEBUG_EXTRA is set

a90c52a

Signed-off-by: DL6ER <dl6er@dl6er.de>

docs: fix simple typo, timestemp -> timestamp

51cfef3

There is a small typo in src/overTime.c. Should read `timestamp` rather than `timestemp`. Signed-off-by: tgates <tim.gates@iress.com>

Merge pull request #980 from timgates42/bugfix_typo_timestamp

d4a1be8

docs: fix simple typo, timestemp -> timestamp

Add interrupt-safe fallocate() routine, due to the special nature of …

fd78858

…the fallocate() macro, we hav to use a modified name fTLallocate() to implement this function Signed-off-by: DL6ER <dl6er@dl6er.de>

Prevent possible deadlock if log is not writable (e.g., permission de…

9627ca6

…nied) Signed-off-by: DL6ER <dl6er@dl6er.de>

Don't fail when trying to free(NULL)

f88b149

Signed-off-by: DL6ER <dl6er@dl6er.de>

Fix Unix socket error handling

b52eb1f

Signed-off-by: DL6ER <dl6er@dl6er.de>

Do not print user change information if there is no user change

0837b8d

Signed-off-by: DL6ER <dl6er@dl6er.de>

Merge branch 'tweak/interruptsafe_systemcalls' into fix/all_the_things

2e0d740

Signed-off-by: DL6ER <dl6er@dl6er.de>

Reply with configured BLOCKINGMODE to blocked CNAME requests

02196cb

Signed-off-by: DL6ER <dl6er@dl6er.de>

Revert "Improve compatibility with old (ancient) kernels"

a66315d

Merge pull request #991 from pi-hole/revert-984-tweak/fallback_ftruncate

e71b6fa

Revert #984

Analyze original question and use it to decide whether we mock an A o…

616bebd

…r AAAA reply when blocking Signed-off-by: DL6ER <dl6er@dl6er.de>

Merge pull request #969 from pi-hole/tweak/interruptsafe_systemcalls

4cd9353

Implement interrupt-safe systemcalls

Merge branch 'development' into fix/all_the_things

db72562

Signed-off-by: DL6ER <dl6er@dl6er.de>

Merge pull request #985 from pi-hole/new/REFRESH_HOSTNAMES_NULL

55c2678

Add UNKNOWN option for REFRESH_HOSTNAME

Don't iterate over all clients every minute trying to find new ones b…

5cca201

…ut only do this when the RESOLVE_NEW_HOSTNAMES event is set Signed-off-by: DL6ER <dl6er@dl6er.de>

Merge pull request #995 from pi-hole/tweak/cname_inspection_blocking

7e81836

Fix CNAME query blocking mode

Merge pull request #996 from pi-hole/tweak/resolve_new_clients_as_event

12e7389

Immediately resolve host names of clients and upstream destinations

Add DEBUG_EXTRA flag (#994)

0eade45

* Add new DEBUG_EXTRA flag used for special (temporary) debugging Signed-off-by: DL6ER <dl6er@dl6er.de>

Escape spaces by ~

e4483bd

Signed-off-by: DL6ER <dl6er@dl6er.de>

Merge pull request #997 from pi-hole/fix/escape_spaces

3506b37

Escape spaces by ~

DL6ER added the Release label Dec 23, 2020

DL6ER requested review from PromoFaux and dschaper December 23, 2020 19:50

PromoFaux approved these changes Dec 23, 2020

View reviewed changes

dschaper approved these changes Dec 23, 2020

View reviewed changes

DL6ER merged commit 66919f2 into master Dec 24, 2020

DL6ER deleted the release/v5.3.3 branch September 10, 2021 06:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pi-hole FTL v5.3.3 #998

Pi-hole FTL v5.3.3 #998

DL6ER commented Dec 23, 2020

Pi-hole FTL v5.3.3 #998

Pi-hole FTL v5.3.3 #998

Conversation

DL6ER commented Dec 23, 2020

New

Tweaks

Fixes