Fix Whitelist buttons on query log pages #1578
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
git rebase
)git commit --signoff
)What does this PR aim to accomplish?:
Fix the behavior of the Whitelist button on both the short-term and long-term query log pages.
Previously, domains blocked due to cases
would blacklist the domain instead of whitelisting it when clicking the Whitelist button.
How does this PR accomplish the above?:
It corrects a typo of
data[5]
by usingarray.indexOf
instead of several===
checks. If===
would be preferable, I can change that upon request.It also corrects the omission of 3 whitelist buttons from the click event, which erroneously blacklisted a domain when clicking the "Whitelist" button.
What documentation changes (if any) are needed to support this PR?:
None