Skip to content

Find Dnsmasq IP leases #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Find Dnsmasq IP leases #647

merged 2 commits into from
Jul 9, 2024

Conversation

jcapona
Copy link
Contributor

@jcapona jcapona commented Jul 5, 2024

Status Ticket/Issue
Ready/Hold Ticket

Main changes

  • Supports finding IP leases made by dnsmasq, as this is the service that provides them in bookworm. This fixes some events that were not triggering in the web portal.

Screenshots (feature, test output, profiling, dev tools etc)

[insert screenshots here]

Other notes (e.g. implementation quirks, edge cases, questions / issues)

Manual testing tips

Tag anyone who definitely needs to review or help

@jcapona jcapona force-pushed the dnsmasq-leases branch 2 times, most recently from 8fd9a9d to 265727b Compare July 9, 2024 14:16
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 93.61702% with 3 lines in your changes missing coverage. Please review.

Project coverage is 59.21%. Comparing base (8174e8c) to head (8584b80).

Files Patch % Lines
packages/common/pitop/common/sys_info.py 93.61% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #647      +/-   ##
==========================================
- Coverage   59.27%   59.21%   -0.06%     
==========================================
  Files         160      160              
  Lines        7998     8033      +35     
==========================================
+ Hits         4741     4757      +16     
- Misses       3257     3276      +19     
Flag Coverage Δ
unittests 59.21% <93.61%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jcapona jcapona marked this pull request as ready for review July 9, 2024 15:11
Copy link
Contributor

@angusjfw angusjfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good (though I didn't run it)

@jcapona jcapona merged commit 5ff45bb into master Jul 9, 2024
7 checks passed
@jcapona jcapona deleted the dnsmasq-leases branch July 9, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants