Dockerize this application #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any update on this @spruce ? |
…using Docker and add .dockerignore to avoid copying some content to the container.
…ding the container everytime the settings.ts file change
…update README with instructions on how to use
…ey want in the Makefile
|
Rebased the PR ^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
With this PR:
Dockerfile, so people with no Node.js installed in their local environments can simply create a Docker container to run the migration process;.dockerignoreto avoid copying some files to the container;Makefileto make it easier to run the Docker commands.Let me know if there is anything you guys would like to change. I have tested this locally and it worked fine.