Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Affine3d -> Isometry3d (Melodic) #7

Conversation

henningkayser
Copy link
Member

This PR changes all references to the in melodic obsolete type Eigen::Affine3d to Eigen::Isometry3d.
(required for the melodic-devel branch of moveit_grasps)

@mlautman
Copy link
Contributor

mlautman commented Apr 8, 2019

My only concern is that this may be being used by someone outside of the MoveIt! community. Perhaps leave the old headers and point them to the isometry versions? Even better would be to use the same fancy templating that gets used in the Eigen project... but that may be too much to ask

@henningkayser
Copy link
Member Author

I think Affine3d shouldn't be used anymore since it's just the wrong type in the robotics context.
What do you think of making the functions deprecated and moving the implementation to the header?

@henningkayser
Copy link
Member Author

@mlautman I added the changes described above. Affine3d is still supported but now deprecated using the C++14 specifiers.

@mlautman mlautman merged commit cae3fc8 into PickNikRobotics:melodic-devel Apr 9, 2019
@henningkayser henningkayser deleted the pr-affine3d_to_isometry3d branch April 16, 2019 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants