Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing WebView2 detection mechanism #2092

Merged
merged 2 commits into from
Dec 23, 2021
Merged

Fixing WebView2 detection mechanism #2092

merged 2 commits into from
Dec 23, 2021

Conversation

lubos
Copy link
Contributor

@lubos lubos commented Dec 23, 2021

Actually I didn't do it quite right. We need to catch WebView2RuntimeNotFoundException when calling GetAvailableBrowserVersionString.

It doesn't seem to be documented anywhere but I don't think GetAvailableBrowserVersionString will ever return null. It's either version string or an exception.

@cwensley
Copy link
Member

Beautiful, thanks!

@cwensley cwensley merged commit 84b2f0c into picoe:develop Dec 23, 2021
@cwensley cwensley added this to the 2.6.1 milestone Jan 11, 2022
@cwensley cwensley added the bug label Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants