Mac: Fix clipping of controls

src/Eto.Mac/Forms/Controls/DrawableHandler.cs

@@ -23,14 +23,20 @@ public override void DrawRect(CGRect dirtyRect)
 				var drawable = Drawable;
 				if (drawable == null)
 					return;
+				// restrict drawing to the bounds of the drawable
+				// macOS can give us dirty rects outside this range
+				var bounds = Bounds.ToEto();
+				var dirty = dirtyRect.ToEto();
+				dirty.Restrict(bounds);
+
 				if (!IsFlipped)
-					dirtyRect.Y = Frame.Height - dirtyRect.Y - dirtyRect.Height;
-				if (dirtyRect.X % 1.0f > 0f)
-					dirtyRect.Width += 1;
-				if (dirtyRect.Y % 1.0f > 0f)
-					dirtyRect.Height += 1;
+					dirty.Y = bounds.Height - dirty.Y - dirty.Height;
+				if (dirty.X % 1.0f > 0f)
+					dirty.Width += 1;
+				if (dirty.Y % 1.0f > 0f)
+					dirty.Height += 1;
 				ApplicationHandler.QueueResizing = true;
-				drawable.DrawRegion(Rectangle.Ceiling(dirtyRect.ToEto()));
+				drawable.DrawRegion(Rectangle.Ceiling(dirty));
 				ApplicationHandler.QueueResizing = false;
 			}
 

src/Eto.Mac/Forms/Controls/ExpanderHandler.cs

@@ -138,6 +138,7 @@ void UpdateExpandedState()
 				{
 					ctx.Duration = 0;
 					((NSView)content.Animator).Frame = startFrame;
+					content.SetClipsToBounds(true);
 				}, () => NSAnimationContext.RunAnimation(ctx =>
 					{
 						ctx.Duration = AnimationDuration;
@@ -147,6 +148,7 @@ void UpdateExpandedState()
 						suspendContentSizing--;
 						content.Hidden = !Expanded;
 						Callback.OnExpandedChanged(Widget, EventArgs.Empty);
+						content.SetClipsToBounds(false);
 						InvalidateMeasure();
 					}
 					)

src/Eto.Mac/Forms/Controls/MacEventView.cs

@@ -15,6 +15,10 @@ public MacEventView()
 			BorderWidth = 0;
 			BorderType = NSBorderType.NoBorder;
 			ContentViewMargins = CGSize.Empty;
+
+			// disable clipping to bounds so buttons/etc aren't clipped, 10.9+
+			this.SetClipsToBounds(false);
+			(ContentView as NSView)?.SetClipsToBounds(false);
 		}
 
 		public MacEventView(IntPtr handle)

src/Eto.Mac/Forms/Controls/NumericStepperHandler.cs

@@ -94,6 +94,8 @@ public EtoNumericStepperView(NumericStepperHandler handler)
 
 				AddSubview(TextField);
 				AddSubview(Stepper);
+
+				this.SetClipsToBounds(false);
 			}
 		}
 

src/Eto.Mac/MacExtensions.cs

@@ -132,6 +132,16 @@ public static CGSize ContentSizeForFrame(this NSScrollView scrollView, CGSize si
 			return Messaging.CGSize_objc_msgSend_CGSize_IntPtr_IntPtr_UInt64_UInt64_Int64(scrollView.ClassHandle, selContentSizeForFrameSize_HorizontalScrollerClass_VerticalScrollerClass_BorderType_ControlSize_ScrollerStyle_Handle, size, hbarPtr, vbarPtr, (ulong)scrollView.BorderType, (ulong)scrollView.VerticalScroller.ControlSize, (long)scrollView.VerticalScroller.ScrollerStyle);
 		}
 
+
+		static readonly IntPtr selSetClipsToBounds = Selector.GetHandle("setClipsToBounds:");
+		static readonly bool supportsClipsToBounds = ObjCExtensions.InstancesRespondToSelector<NSView>(selSetClipsToBounds);
+
+		public static void SetClipsToBounds(this NSView view, bool clipsToBounds)
+		{
+			if (!supportsClipsToBounds)
+				return;
+			Messaging.void_objc_msgSend_bool(view.Handle, selSetClipsToBounds, clipsToBounds);
+		}
 	}
 }