Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use chroma red and green for color-green and color-red #2

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

jshawl
Copy link
Contributor

@jshawl jshawl commented Jan 4, 2024

This PR updates the green and red colors to match the green and red provided by chroma. I thought the brighter green was a little hard to read and thought using the existing green on the page would improve the readability.

I also checked that the --success and --error variables were not being used elsewhere:

$ git grep -n -e '--error' -e '--success'
static/main.css:32:    --success: #50fa7b;
static/main.css:33:    --error: #ff5555;
static/main.css:51:    --success: #50fa7b;
static/main.css:52:    --error: #ff5555;
static/main.css:254:  color: var(--success);
static/main.css:258:  color: var(--error);

Before

Screenshot 2024-01-03 at 19 45 14

After

Screenshot 2024-01-03 at 19 42 44

@jshawl jshawl marked this pull request as ready for review January 4, 2024 01:52
Copy link
Member

@neurosnap neurosnap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks so much!

@neurosnap neurosnap merged commit 4de794d into picosh:main Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants