Adding notes objects to be retrieved with base post class #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution. Looks all good to me. I don't have the time right now to test (I really should set up a test suite/CI at some point) but just reading your source looks good from what I remember about the JSON API. |
|
Spiffy :D Is this going to go out to the NuGet package? (I'd rather use that than importing the projects, obviously. :) ) |
Closed
|
I'm going to set up AppVeyor to automatically build master and upload to NuGet. I'll update soon. |
|
I've published the latest version with the PR changes to NuGet, and set up an automatic build/deploy when commits go to master. Let me know if you have any problems as I'm still pretty new to NuGet in general! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I'm in need of your library for a fairly urgent update to a site I run to allow it to interact with Tumblr's OAuth flow; however, discovered in the process that you don't yet have the notes objects populated when mapping from Tumblr's responses, which I also need. Took the liberty of adding it myself for a PR; fairly simple object structure update and Newtonsoft does most of the work, but let me know if you need any further updates on my end!