Skip to content

Conversation

59naga
Copy link
Contributor

@59naga 59naga commented Jul 30, 2018

#17 (comment)
I restored the old index.js on the side of the index.mjs as the new code broke the old behavior promised by this library i.e. it is a drop-in replacement for package 'assert'. So by default it should work the same as 'assert'. Now it won't work for e.g. assert(true), but you must use assert.default(true) etc. so it's not a drop-in replacement anymore. Do you have an idea how the module exports could work in the new system as before so assert(true) could work without having to use require('assert-diff').default ?

Can delete .default using webpack's UMD (as published @59naga/assert-diff@2.0.2).

yarn add -D @59naga/assert-diff
var assert = require('@59naga/assert-diff')
assert.deepEqual({a: 1}, {a: 1}, 'this should not fail')

@pihvi pihvi merged commit 17f7b88 into pihvi:master Jul 30, 2018
@pihvi
Copy link
Owner

pihvi commented Jul 30, 2018

Perfect, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants