-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New region color codes + additional colors for Transport #40
New region color codes + additional colors for Transport #40
Conversation
…nsport_colors Build library
This reverts commit fefe37c.
…nsport_colors Update branch
This PR now includes new transport as well as new region color codes: Comparison for H12 regions: Comparison for EUR regions: Test Transport CompScens to zoom in can be found here: https://cloud.pik-potsdam.de/index.php/s/r2ndPG2D6nCS86y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I got some minor questions 🙂
inst/extdata/plotstyle.csv
Outdated
@@ -215,26 +215,41 @@ Trade|Primary Energy|Coal|Value;Coal;#999959;; | |||
Trade|Primary Energy|Gas|Value;Gas;#191999;; | |||
Trade|Primary Energy|Oil|Value;Oil;#337fff;; | |||
Trade|Uranium|Value;Uranium;#33ff00;; | |||
CAZ;;#e6194B;; | |||
CHA;;#3cb44b;; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like an extended name missing for some country codes, is this intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, I just don't know the extended names to all regions (I can look into a mapping what countries are included but I guess its not intended here to have a list of countries as description)
Co-authored-by: Pascal Führlich <82826417+pfuehrlich-pik@users.noreply.github.com>
CAZ;;#e6194B;; | ||
CHA;;#3cb44b;; | ||
CAZ;Canada;#e6194B;; | ||
CHA;mainly China;#3cb44b;; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be sure, you did not mean "mainland China" here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No its China and some other countries
I will unsubscribe from this PR for now, let me know if you need another review 🙂 |
Add differentiation between LDV Four Wheelers and LDV Two Wheelers