Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New region color codes + additional colors for Transport #40

Merged
merged 11 commits into from
Nov 25, 2022

Conversation

johannah-pik
Copy link
Contributor

Add differentiation between LDV Four Wheelers and LDV Two Wheelers

@johannah-pik johannah-pik marked this pull request as draft November 10, 2022 10:30
@johannah-pik
Copy link
Contributor Author

johannah-pik commented Nov 10, 2022

This PR now includes new transport as well as new region color codes:
-Every region out of the 21 has its own color code
-Color codes were chosen (if possible) close to the old ones

Comparison for H12 regions:
Old
image
New
image

Comparison for EUR regions:
Old:
imageimage

New:
imageimage

Test Transport CompScens to zoom in can be found here: https://cloud.pik-potsdam.de/index.php/s/r2ndPG2D6nCS86y
PW: S6eGCd9G

@johannah-pik johannah-pik changed the title Update transport colors New region color codes + additional colors for Transport Nov 10, 2022
Copy link
Contributor

@pfuehrlich-pik pfuehrlich-pik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I got some minor questions 🙂

@@ -215,26 +215,41 @@ Trade|Primary Energy|Coal|Value;Coal;#999959;;
Trade|Primary Energy|Gas|Value;Gas;#191999;;
Trade|Primary Energy|Oil|Value;Oil;#337fff;;
Trade|Uranium|Value;Uranium;#33ff00;;
CAZ;;#e6194B;;
CHA;;#3cb44b;;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an extended name missing for some country codes, is this intended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I just don't know the extended names to all regions (I can look into a mapping what countries are included but I guess its not intended here to have a list of countries as description)

inst/extdata/plotstyle.csv Outdated Show resolved Hide resolved
inst/extdata/plotstyle.csv Outdated Show resolved Hide resolved
johannah-pik and others added 3 commits November 10, 2022 14:41
Co-authored-by: Pascal Führlich <82826417+pfuehrlich-pik@users.noreply.github.com>
CAZ;;#e6194B;;
CHA;;#3cb44b;;
CAZ;Canada;#e6194B;;
CHA;mainly China;#3cb44b;;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure, you did not mean "mainland China" here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No its China and some other countries

@johannah-pik
Copy link
Contributor Author

Update: Red and yellow colors for main OECD regions
image

@pfuehrlich-pik
Copy link
Contributor

I will unsubscribe from this PR for now, let me know if you need another review 🙂

@johannah-pik johannah-pik marked this pull request as ready for review November 25, 2022 13:57
@johannah-pik johannah-pik merged commit 275eadb into pik-piam:master Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants