Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up errors module #365

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Clean up errors module #365

merged 1 commit into from
Aug 18, 2022

Conversation

msimberg
Copy link
Contributor

Part of #16.

The main changes are making pika::error and pika::throwmode class enums. In addition to that some functions were moved to detail.

@msimberg msimberg added this to the 0.8.0 milestone Aug 10, 2022
@msimberg msimberg force-pushed the cleanup-errors branch 3 times, most recently from b6a72a2 to d9185c7 Compare August 10, 2022 12:06
@msimberg
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Aug 10, 2022
@bors
Try #365:
da973ea
@bors
Copy link
Contributor

bors bot commented Aug 10, 2022

try

Build failed:

@msimberg
Copy link
Contributor Author

bors try-

@msimberg
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Aug 10, 2022
@bors
Try #365:
aaffbf8
@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)(=)(=)

Info

PropertyBeforeAfter
pika Commitd45937d303b256
pika Datetime2022-05-17T10:12:00+00:002022-08-10T12:06:17+00:00
Datetime2022-05-17T12:20:04.953138+02:002022-08-10T14:08:53.821388+02:00
Clusternamedaintdaint
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Envfile
Hostnamenid01398nid00025

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch+

Info

PropertyBeforeAfter
pika Commit453f6a4303b256
pika Datetime2022-06-24T10:19:16+00:002022-08-10T12:06:17+00:00
Datetime2022-06-24T12:43:43.615347+02:002022-08-10T14:09:08.320611+02:00
Clusternamedaintdaint
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Envfile
Hostnamenid00025nid00025

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
Stream Benchmark - Add--(=)(=)
Stream Benchmark - Scale+++(=)+++
Stream Benchmark - Triad+++++
Stream Benchmark - Copy(=)==

Info

PropertyBeforeAfter
pika Commitd45937d303b256
pika Datetime2022-05-17T10:12:00+00:002022-08-10T12:06:17+00:00
Datetime2022-05-17T12:20:34.006375+02:002022-08-10T14:09:23.071000+02:00
Clusternamedaintdaint
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Envfile
Hostnamenid01398nid00025

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@bors
Copy link
Contributor

bors bot commented Aug 10, 2022

try

Build failed:

@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)(=)(=)

Info

PropertyBeforeAfter
pika Datetime2022-05-17T10:12:00+00:002022-08-10T12:09:31+00:00
pika Commitd45937dce0427f
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Envfile
Clusternamedaintdaint
Datetime2022-05-17T12:20:04.953138+02:002022-08-10T14:13:45.570033+02:00
Hostnamenid01398nid00025

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch-

Info

PropertyBeforeAfter
pika Datetime2022-06-24T10:19:16+00:002022-08-10T12:09:31+00:00
pika Commit453f6a4ce0427f
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Envfile
Clusternamedaintdaint
Datetime2022-06-24T12:43:43.615347+02:002022-08-10T14:14:00.575416+02:00
Hostnamenid00025nid00025

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
Stream Benchmark - Add(=)(=)(=)
Stream Benchmark - Scale+++(=)+++
Stream Benchmark - Triad+++++
Stream Benchmark - Copy(=)(=)=

Info

PropertyBeforeAfter
pika Datetime2022-05-17T10:12:00+00:002022-08-10T12:09:31+00:00
pika Commitd45937dce0427f
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Envfile
Clusternamedaintdaint
Datetime2022-05-17T12:20:34.006375+02:002022-08-10T14:14:15.135098+02:00
Hostnamenid01398nid00025

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@msimberg
Copy link
Contributor Author

bors try-

@msimberg
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Aug 10, 2022
@bors
Try #365:
2152f4e
@bors
Copy link
Contributor

bors bot commented Aug 10, 2022

try

Build failed:

@msimberg msimberg force-pushed the cleanup-errors branch 2 times, most recently from 6c5e907 to 0c2ae84 Compare August 10, 2022 12:26
@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)(=)(=)

Info

PropertyBeforeAfter
pika Commitd45937d9d83e28
pika Datetime2022-05-17T10:12:00+00:002022-08-10T12:26:06+00:00
Envfile
Datetime2022-05-17T12:20:04.953138+02:002022-08-10T14:29:38.873797+02:00
Hostnamenid01398nid00279
Clusternamedaintdaint
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch+

Info

PropertyBeforeAfter
pika Commit453f6a49d83e28
pika Datetime2022-06-24T10:19:16+00:002022-08-10T12:26:06+00:00
Envfile
Datetime2022-06-24T12:43:43.615347+02:002022-08-10T14:29:53.520179+02:00
Hostnamenid00025nid00279
Clusternamedaintdaint
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
Stream Benchmark - Add(=)(=)--
Stream Benchmark - Scale+++(=)+++
Stream Benchmark - Triad(=)++++
Stream Benchmark - Copy(=)(=)(=)

Info

PropertyBeforeAfter
pika Commitd45937d9d83e28
pika Datetime2022-05-17T10:12:00+00:002022-08-10T12:26:06+00:00
Envfile
Datetime2022-05-17T12:20:34.006375+02:002022-08-10T14:30:08.300452+02:00
Hostnamenid01398nid00279
Clusternamedaintdaint
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@msimberg
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Aug 10, 2022
@bors
Try #365:
0a08cfc
@bors
Copy link
Contributor

bors bot commented Aug 10, 2022

try

Build failed:

@msimberg msimberg self-assigned this Aug 10, 2022
@msimberg
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Aug 10, 2022
@bors
Try #365:
b066d0a
@bors
Copy link
Contributor

bors bot commented Aug 10, 2022

try

Build succeeded:

@msimberg msimberg mentioned this pull request Aug 16, 2022
Open
59 tasks
aurianer
aurianer approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@aurianer aurianer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

libs/pika/errors/include/pika/errors/error_code.hpp Show resolved Hide resolved
libs/pika/errors/include/pika/errors/exception.hpp Show resolved Hide resolved
libs/pika/futures/src/future_data.cpp Show resolved Hide resolved
@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)(=)(=)

Info

PropertyBeforeAfter
pika Commitd45937d2c99131
pika Datetime2022-05-17T10:12:00+00:002022-08-17T08:24:27+00:00
Clusternamedaintdaint
Hostnamenid01398nid01193
Datetime2022-05-17T12:20:04.953138+02:002022-08-17T10:31:13.640192+02:00
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Envfile

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch+

Info

PropertyBeforeAfter
pika Commit453f6a42c99131
pika Datetime2022-06-24T10:19:16+00:002022-08-17T08:24:27+00:00
Clusternamedaintdaint
Hostnamenid00025nid01193
Datetime2022-06-24T12:43:43.615347+02:002022-08-17T10:31:28.271975+02:00
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Envfile

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
Stream Benchmark - Add(=)(=)-
Stream Benchmark - Scale+++(=)+++
Stream Benchmark - Triad+++++
Stream Benchmark - Copy(=)(=)(=)

Info

PropertyBeforeAfter
pika Commitd45937d2c99131
pika Datetime2022-05-17T10:12:00+00:002022-08-17T08:24:27+00:00
Clusternamedaintdaint
Hostnamenid01398nid01193
Datetime2022-05-17T12:20:34.006375+02:002022-08-17T10:31:42.960603+02:00
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Envfile

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@msimberg
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Aug 17, 2022
@bors
Try #365:
4c46df9
@bors
Copy link
Contributor

bors bot commented Aug 17, 2022

try

Build failed:

@msimberg
Copy link
Contributor Author

bors merge

bors bot added a commit that referenced this pull request Aug 17, 2022
@bors @msimberg
Merge #365
d8d0013 
365: Clean up `errors` module r=msimberg a=msimberg

Part of #16.

The main changes are making `pika::error` and `pika::throwmode` class enums. In addition to that some functions were moved to `detail`.

Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
@bors
Copy link
Contributor

bors bot commented Aug 17, 2022

Build failed:

@msimberg
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Aug 18, 2022

Build succeeded:

@bors bors bot merged commit 26fecda into pika-org:main Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aurianer aurianer aurianer approved these changes

@biddisco biddisco Awaiting requested review from biddisco biddisco is a code owner

Assignees

@msimberg msimberg

Labels
None yet
Projects
pika planning board
Archived in project
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@msimberg @pika-bot @aurianer