-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up errors
module
#365
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msimberg
force-pushed
the
cleanup-errors
branch
3 times, most recently
from
August 10, 2022 12:06
b6a72a2
to
d9185c7
Compare
bors try |
tryBuild failed: |
msimberg
force-pushed
the
cleanup-errors
branch
from
August 10, 2022 12:09
d9185c7
to
e5d3993
Compare
bors try- |
bors try |
Performance test reportpika PerformanceComparison
Info
Comparison
Info
Comparison
Info
Explanation of Symbols
|
tryBuild failed: |
msimberg
force-pushed
the
cleanup-errors
branch
from
August 10, 2022 12:14
e5d3993
to
743c487
Compare
Performance test reportpika PerformanceComparison
Info
Comparison
Info
Comparison
Info
Explanation of Symbols
|
bors try- |
bors try |
tryBuild failed: |
msimberg
force-pushed
the
cleanup-errors
branch
2 times, most recently
from
August 10, 2022 12:26
6c5e907
to
0c2ae84
Compare
Performance test reportpika PerformanceComparison
Info
Comparison
Info
Comparison
Info
Explanation of Symbols
|
msimberg
force-pushed
the
cleanup-errors
branch
from
August 10, 2022 12:36
0c2ae84
to
4dd2fd8
Compare
bors try |
tryBuild failed: |
msimberg
force-pushed
the
cleanup-errors
branch
from
August 10, 2022 12:50
4dd2fd8
to
b63d430
Compare
bors try |
59 tasks
aurianer
approved these changes
Aug 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
msimberg
force-pushed
the
cleanup-errors
branch
from
August 17, 2022 08:24
b63d430
to
6f79997
Compare
Performance test reportpika PerformanceComparison
Info
Comparison
Info
Comparison
Info
Explanation of Symbols
|
bors try |
tryBuild failed: |
bors merge |
Build failed: |
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #16.
The main changes are making
pika::error
andpika::throwmode
class enums. In addition to that some functions were moved todetail
.