-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move everything except public functionality to detail namespace #16
Labels
effort: 3
A few days of work.
effort: 4
A few weeks of work.
priority: low
Nice to have, but nobody is going to be sad if this is never done.
type: refactoring
Comments
msimberg
added
effort: 3
A few days of work.
effort: 4
A few weeks of work.
priority: medium
This should be done sooner or later.
type: refactoring
labels
Jan 18, 2022
This was referenced Mar 25, 2022
This was referenced Mar 29, 2022
Merged
bors bot
added a commit
that referenced
this issue
Apr 7, 2022
166: Clean up `version` module r=msimberg a=aurianer Part of #16. Removes hwloc, boost and mpi dependency in the `version` module. 176: Add missing includes to `transform_mpi.hpp` r=msimberg a=msimberg I missed this in #156 :/ Potentially worth a 0.3.1, or at least a patch in the spack package. Co-authored-by: Auriane R <aurianer@cscs.ch> Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
bors bot
added a commit
that referenced
this issue
Apr 27, 2022
196: Clean up `async_cuda` module r=msimberg a=msimberg Part of #16. ## Proposed Changes - Removes CUDA/cuBLAS executors. - Removes CUDA futures. - Translates CUDA/cuBLAS executor/future examples/tests with the straightforward sender equivalent (I've put very little effort into optimizing/cleaning up). I've "unseparated" the `cuda_future` test into a single `cu` file since it's easier to manage the template instantiations like that. - Moves some helper functionality into `detail`. Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
bors bot
added a commit
that referenced
this issue
May 10, 2022
216: Clean up `command_line_handling` module r=aurianer a=msimberg Part of #16. There wasn't much to clean up. The biggest change is making `commandline_error_mode` into an `enum class` and adding helper functions for dealing with it. Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
This was referenced May 31, 2022
Merged
bors bot
added a commit
that referenced
this issue
Feb 23, 2023
607: Clean up `hardware` module r=msimberg a=msimberg Part of #16. This moves the `timestamp` functionality to the `timing` module, and removes the unused `bit_manipulation.hpp` header. This leaves nothint in the `hardware` module, so it is removed. Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
This was referenced Mar 27, 2023
Merged
bors bot
added a commit
that referenced
this issue
Mar 28, 2023
631: Clean up the `hashing` module r=msimberg a=msimberg Part of #16. 632: Clean up `include` module r=msimberg a=msimberg Part of #16. Remove includes that contain detail-only functionality from e.g. `pika/functional.hpp`. Replace includes of `pika/functional.hpp` with more specific includes when required for detail functionality. Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
bors bot
added a commit
that referenced
this issue
Mar 28, 2023
628: Miscellaneous cleanup of debug print macros r=msimberg a=msimberg - Rename macros to be prefixed by `PIKA_DETAIL` - Remove unnecessary casts in debug print macro calls - Add note about meaning of detail to README 634: Clean up `init_runtime` module r=msimberg a=msimberg Part of #16. Move functionality into `detail` namespace, move functions into cpp files. 638: Fix option description for `PIKA_WITH_THREAD_DEBUG_INFO` r=msimberg a=msimberg The option is not implicitly enabled in debug builds. Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
bors bot
added a commit
that referenced
this issue
Mar 28, 2023
634: Clean up `init_runtime` module r=msimberg a=msimberg Part of #16. Move functionality into `detail` namespace, move functions into cpp files. 638: Fix option description for `PIKA_WITH_THREAD_DEBUG_INFO` r=msimberg a=msimberg The option is not implicitly enabled in debug builds. Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
msimberg
added
priority: low
Nice to have, but nobody is going to be sad if this is never done.
and removed
priority: medium
This should be done sooner or later.
labels
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
effort: 3
A few days of work.
effort: 4
A few weeks of work.
priority: low
Nice to have, but nobody is going to be sad if this is never done.
type: refactoring
The public API of pika is small: sender/receiver functionality, runtime initialization, what else?
Hidden functionality can then gradually be brought into the public namespace through
pika::experimental::
or directly intopika::
.The only reasonable way to do this is module by module:
algorithms
module part 1 #377, Move more algorithms/execution traits into detail namespace #411, More algorithms module namespace cleanup #475)async_base
module #158)async_combinators
module #160)async_cuda
module #196)async_mpi
module #374)command_line_handling
module #216)datastructures
module #276)errors
module #365)functional
module #380)futures
module #525)hardware
module #607)hashing
module #631)include
module #632)ini
module functionality into detail namespace #633)init_runtime
module #634)string_util
module #595)tag_invoke
module #596) (Replace pika'sinvoke_result
withstd::invoke_result
#599)thread_pool_util
module #509)thread_pools
module #462)thread_support
module #461)version
module #166)This is also a good opportunity to do general cleanup.
Avoid nesting
detail
namespaces intoexperimental
namespace #448The text was updated successfully, but these errors were encountered: