Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up namespaces etc. in execution modules #508

Merged
merged 6 commits into from
Nov 21, 2022
Merged

Clean up namespaces etc. in execution modules #508

merged 6 commits into from
Nov 21, 2022

Conversation

msimberg
Copy link
Contributor

Part of #16.

@msimberg msimberg added this to the 0.11.0 milestone Nov 11, 2022
@msimberg msimberg self-assigned this Nov 11, 2022
@msimberg
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Nov 11, 2022
@bors
Try #508:
b0cf8a5
@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)(=)(=)

Info

PropertyBeforeAfter
pika Commitd45937dd3cfc8a
pika Datetime2022-05-17T10:12:00+00:002022-11-11T13:38:39+00:00
Envfile
Hostnamenid01398nid01616
Datetime2022-05-17T12:20:04.953138+02:002022-11-11T14:57:44.908680+01:00
Clusternamedaintdaint
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch++

Info

PropertyBeforeAfter
pika Commit190f189d3cfc8a
pika Datetime2022-09-16T08:18:06+00:002022-11-11T13:38:39+00:00
Envfile
Hostnamenid00074nid01616
Datetime2022-09-16T10:25:01.976661+02:002022-11-11T14:57:59.226952+01:00
Clusternamedaintdaint
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
Stream Benchmark - Add--(=)++
Stream Benchmark - Scale+++(=)++
Stream Benchmark - Triad+++++
Stream Benchmark - Copy(=)(=)(=)

Info

PropertyBeforeAfter
pika Commitd45937dd3cfc8a
pika Datetime2022-05-17T10:12:00+00:002022-11-11T13:38:39+00:00
Envfile
Hostnamenid01398nid01616
Datetime2022-05-17T12:20:34.006375+02:002022-11-11T14:58:14.064127+01:00
Clusternamedaintdaint
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@bors
Copy link
Contributor

bors bot commented Nov 11, 2022

try

Build failed:

@msimberg
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Nov 11, 2022
@bors
Try #508:
39c6396
@bors
Copy link
Contributor

bors bot commented Nov 11, 2022

try

Build failed:

@msimberg
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Nov 11, 2022
@bors
Try #508:
d47ebcf
@bors
Copy link
Contributor

bors bot commented Nov 11, 2022

try

Build succeeded:

@msimberg
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Nov 14, 2022
@bors
Try #508:
44a6280
@bors
Copy link
Contributor

bors bot commented Nov 14, 2022

try

Build failed:

aurianer
aurianer approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@aurianer aurianer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks a lot!

@aurianer aurianer mentioned this pull request Nov 15, 2022
Open
59 tasks
@msimberg
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Nov 21, 2022

Build succeeded:

@bors bors bot merged commit d85ea2c into pika-org:main Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aurianer aurianer aurianer approved these changes

@biddisco biddisco Awaiting requested review from biddisco biddisco is a code owner

Assignees

@msimberg msimberg

Labels
None yet
Projects
pika planning board
Archived in project
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@msimberg @pika-bot @aurianer