Skip to content

Do not delete and recreate index on class definitions save #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lukmzig
Copy link
Contributor

@lukmzig lukmzig commented Apr 4, 2024

Changes in this pull request

Resolves #127

@lukmzig lukmzig added this to the 1.1.0 milestone Apr 4, 2024
@lukmzig lukmzig linked an issue Apr 4, 2024 that may be closed by this pull request
@lukmzig lukmzig requested a review from markus-moser April 4, 2024 14:28
Copy link

github-actions bot commented Apr 4, 2024

Qodana for PHP

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Base automatically changed from 130-deployment-strategy to 1.x April 8, 2024 06:07
lukmzig and others added 2 commits April 8, 2024 08:09
…-definitions-save

# Conflicts:
#	src/EventSubscriber/ClassDefinitionIndexSubscriber.php
#	src/Service/SearchIndex/IndexService/IndexHandler/AbstractIndexHandler.php
#	src/Service/SearchIndex/IndexService/IndexHandler/IndexHandlerInterface.php
#	tests/Functional/SearchIndex/DataObjectBasicTest.php
@lukmzig lukmzig requested a review from markus-moser April 8, 2024 06:28
Copy link
Contributor

@markus-moser markus-moser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@lukmzig lukmzig merged commit 2ebe0eb into 1.x Apr 16, 2024
@lukmzig lukmzig deleted the 127-do-not-delete-and-recreate-index-on-class-definitions-save branch April 16, 2024 08:12
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not delete and recreate index on class definitions save
2 participants