Skip to content

Conversation

mattamon
Copy link
Contributor

@mattamon mattamon commented Oct 3, 2024

Changes in this pull request

Resolves #171

Additional info

Introducing type specific interfaces to avoid problems, like creating an asset search that is compatible with an element search.

@mattamon mattamon added this to the 2.0.0 milestone Oct 3, 2024
Copy link

sonarqubecloud bot commented Oct 7, 2024

@mattamon mattamon requested a review from martineiber October 7, 2024 06:31
Copy link
Contributor

@martineiber martineiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦭

@mattamon mattamon merged commit 95ef63c into 1.x Oct 7, 2024
11 checks passed
@mattamon mattamon deleted the 171-introduce-specific-search-interfaces branch October 7, 2024 11:39
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2024
@mattamon mattamon restored the 171-introduce-specific-search-interfaces branch October 7, 2024 11:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] SearchProviderInterface createAssetSearch returns all elements
2 participants