Skip to content

PD-95 Add Table Type to TextKeywordAdapter. #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 15, 2024
Merged

PD-95 Add Table Type to TextKeywordAdapter. #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bb617b
PD-95 Add Table to TextAdapter. And Add a Unit Test.
martineiber Feb 15, 2024
7c445c5
Apply php-cs-fixer changes
martineiber Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/services/search/data-object/field-definition-adapters.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ services:
- { name: "pimcore.generic_data_index.data-object.search_index_field_definition", type: "countrymultiselect" }
- { name: "pimcore.generic_data_index.data-object.search_index_field_definition", type: "language" }
- { name: "pimcore.generic_data_index.data-object.search_index_field_definition", type: "languagemultiselect" }
- { name: "pimcore.generic_data_index.data-object.search_index_field_definition", type: "table" }

Pimcore\Bundle\GenericDataIndexBundle\Service\SearchIndex\DataObject\FieldDefinitionAdapter\NumericAdapter:
shared: false
Expand Down
45 changes: 45 additions & 0 deletions tests/Unit/Service/SearchIndex/DataObject/FieldDefinitionAdapter/TextKeywordAdapterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
<?php
declare(strict_types=1);

/**
* Pimcore
*
* This source file is available under following license:
* - Pimcore Commercial License (PCL)
*
* @copyright Copyright (c) Pimcore GmbH (http://www.pimcore.org)
* @license http://www.pimcore.org/license PCL
*/

namespace Pimcore\Bundle\GenericDataIndexBundle\Tests\Unit\Service\SearchIndex\DataObject\FieldDefinitionAdapter;

use Codeception\Test\Unit;
use Pimcore\Bundle\GenericDataIndexBundle\Service\SearchIndex\DataObject\FieldDefinitionAdapter\TextKeywordAdapter;
use Pimcore\Bundle\GenericDataIndexBundle\Service\SearchIndex\DataObject\FieldDefinitionServiceInterface;
use Pimcore\Bundle\GenericDataIndexBundle\Service\SearchIndex\SearchIndexConfigServiceInterface;

/**
* @internal
*/
final class TextKeywordAdapterTest extends Unit
{
public function testGetOpenSearchMapping(): void
{
$searchIndexConfigServiceInterfaceMock = $this->makeEmpty(SearchIndexConfigServiceInterface::class);
$fieldDefinitionServiceInterfaceMock = $this->makeEmpty(FieldDefinitionServiceInterface::class);
$adapter = new TextKeywordAdapter(
$searchIndexConfigServiceInterfaceMock,
$fieldDefinitionServiceInterfaceMock
);

$mapping = $adapter->getOpenSearchMapping();
$this->assertSame([
'type' => 'text',
'fields' => [
'keyword' => [
'type' => 'keyword',
],
],
], $mapping);
}
}