Skip to content

Conversation

martineiber
Copy link
Contributor

Changes in this pull request

Resolves #64

Additional info

@martineiber martineiber added this to the 1.0.0 milestone Feb 28, 2024
@martineiber martineiber changed the title #64 Decouple Adapters from OpenSearch. #64 Decouple OpenSearch field definition adapter mappings. Feb 28, 2024
Copy link

github-actions bot commented Feb 28, 2024

Qodana for PHP

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@martineiber martineiber force-pushed the 64-decouple-opensearch-field-definition-adapter-mappings-from-concrete-implementation branch from f8a5b5e to a72e5fc Compare February 28, 2024 14:27
@martineiber martineiber marked this pull request as ready for review February 28, 2024 15:32
Copy link
Contributor

@markus-moser markus-moser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's solve it like this

Copy link
Contributor

@lukmzig lukmzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@martineiber martineiber merged commit 725dd51 into 1.x Feb 29, 2024
@martineiber martineiber deleted the 64-decouple-opensearch-field-definition-adapter-mappings-from-concrete-implementation branch February 29, 2024 09:51
@github-actions github-actions bot locked and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decouple OpenSearch field definition adapter mappings from concrete implementation
3 participants