Skip to content

[Task] Add missing methods #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 25, 2025
Merged

[Task] Add missing methods #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e54f246
Add missing methods
martineiber Sep 25, 2025
22f8bad
Only Exclude those from test.
martineiber Sep 25, 2025
cc7f010
Only Exclude those from test.
martineiber Sep 25, 2025
8724e4c
Remove Namespace
martineiber Sep 25, 2025
8f51324
Fix Check
martineiber Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tests/Unit/Models/Assets/AssetResolverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@
#[Group('contract')]
class AssetResolverTest extends ContractAbstractTest
{
public array $excludedMethods = [
'setGetInheritedProperties',
'getGetInheritedProperties'
];

public array $exludeMethodsForReturnTypeCheck = ['getByPath', 'getById'];

protected function getClassToTest(): string {
Expand Down
6 changes: 5 additions & 1 deletion tests/Unit/Models/DataObject/ConcreteObjectResolverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,11 @@
#[Group('contract')]
class ConcreteObjectResolverTest extends ContractAbstractTest
{
public array $excludedMethods = ['__callStatic'];
public array $excludedMethods = [
'__callStatic',
'setGetInheritedProperties',
'getGetInheritedProperties'
];

public array $exludeMethodsForReturnTypeCheck = ['getById', 'getByPath'];

Expand Down
6 changes: 5 additions & 1 deletion tests/Unit/Models/DataObject/DataObjectFolderResolverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,11 @@
#[Group('contract')]
class DataObjectFolderResolverTest extends ContractAbstractTest
{
public array $excludedMethods = ['__callStatic'];
public array $excludedMethods = [
'__callStatic',
'setGetInheritedProperties',
'getGetInheritedProperties'
];

public array $exludeMethodsForReturnTypeCheck = ['getById', 'getByPath'];

Expand Down
6 changes: 5 additions & 1 deletion tests/Unit/Models/DataObject/DataObjectResolverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,11 @@
#[Group('contract')]
class DataObjectResolverTest extends ContractAbstractTest
{
public array $excludedMethods = ['__callStatic'];
public array $excludedMethods = [
'__callStatic',
'setGetInheritedProperties',
'getGetInheritedProperties'
];

public array $exludeMethodsForReturnTypeCheck = ['getById', 'getByPath'];

Expand Down
11 changes: 10 additions & 1 deletion tests/Unit/Models/Document/DocumentResolverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,16 @@
#[Group('contract')]
class DocumentResolverTest extends ContractAbstractTest
{
public array $exludeMethodsForReturnTypeCheck = ['getByPath', 'getById', 'create'];
public array $excludedMethods = [
'setGetInheritedProperties',
'getGetInheritedProperties'
];

public array $exludeMethodsForReturnTypeCheck = [
'getByPath',
'getById',
'create'
];

protected function getClassToTest(): string {
return Document::class;
Expand Down