Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement of http destination #15

Closed
wants to merge 4 commits into from
Closed

Conversation

ThisIsBenny
Copy link

@ThisIsBenny ThisIsBenny commented Aug 13, 2022

  • handle status codes 200, 201 and 202 as success
  • remove upload files only on success
  • use result.close() to avoid memory issues

Benny added 4 commits August 13, 2022 10:39
…oid memory issues

Signed-off-by: Benny <benny@hierl.dev>
Signed-off-by: Benny <benny@hierl.dev>
Signed-off-by: Benny <benny@hierl.dev>
Signed-off-by: Benny <benny@hierl.dev>
@tbbuck
Copy link

tbbuck commented Aug 17, 2022

I've tested this on my Enviro Urban and can confirm the result.close() fixes the issue where (for me) only 3 readings could be sent at a time before memory issues prevented the rest going through.

@Gadgetoid
Copy link
Member

If I'm being pedantic I'd say the if statement should be reversed so that not in becomes in. Otherwise this looks good, thank you! Just waiting on @lowfatcode to have a moment spare from EPIC FONT STUFF to review this.

@lowfatcode
Copy link
Member

Thanks all! I had been messing with the HTTP endpoint already so have manually added these fixes: cafed06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants