Handle user supplied LineRequest/offset. #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client libraries will use get_pin() to resolve a user-supplied or default pin label to a gpiochip and line offset. If the user decides to supply a LineRequest, offset tuple instead, then simply return it. This avoids having to handle this behaviour in every client library.
Pull Request Test Coverage Report for Build 8802799399Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client libraries will use get_pin() to resolve a user-supplied or default pin label to a gpiochip and line offset.
This is intended to fix the issues with Buster not including pin labels - pimoroni/enviroplus-python#137 - though we do not want to make a habit of supporting anything older than Bullseye.
This should also fix other cases where a user supplies a
(LineRequest, offset)tuple instead of a"GPIO27"label. Since the user has already done the legwork of requesting the pin and supplying it to the library, we can return it verbatim. This avoids having to handle this behaviour in every client library.