Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Palette definition of Orange in invalid #89

Closed
pricorde opened this issue Dec 31, 2020 · 2 comments
Closed

Palette definition of Orange in invalid #89

pricorde opened this issue Dec 31, 2020 · 2 comments

Comments

@pricorde
Copy link

In inky_uc8159.py the color definition for Orange in the saturated palette is [77, 106, 73] (see line 44 of inky_uc8159.py).
These values are more greenish than orange.
I think there is a mistake in this RGB value.

Gadgetoid added a commit that referenced this issue Jan 11, 2021
@Gadgetoid
Copy link
Member

I produced these values with the incredibly unscientific method of taking a photo of Inky in white-ish lighting, blurring the result and picking up the colour of each bar. You're right... it's very, very not orange.

I think it should have been "177" and not "77".

Gadgetoid added a commit that referenced this issue Jan 29, 2021
@Gadgetoid
Copy link
Member

Should be fixed as of v1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants