Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jpg decode options #941

Closed
exussum12 opened this issue May 21, 2024 · 4 comments
Closed

Add jpg decode options #941

exussum12 opened this issue May 21, 2024 · 4 comments
Assignees
Labels

Comments

@exussum12
Copy link
Contributor

https://github.com/pimoroni/pimoroni-pico/blob/f3b53b6b5ffd37202fc0de4fab4f159d551b7a24/libraries/jpegdec/JPEGDEC.h#L220C9-L220C15

seems to be an older version

https://github.com/bitbank2/JPEGDEC/pull/55/files

Added support for offsetting

@Gadgetoid Gadgetoid self-assigned this May 21, 2024
@Gadgetoid
Copy link
Member

OOh good catch, this is a useful feature for dealing with single file sprite, icon or tile sheets. Though jpeg is still a little suboptimal for those in general.

This was referenced May 30, 2024
@Gadgetoid
Copy link
Member

Uhhh.. The linked PR was rejected and those changes aren't actually part of JPEGDEC at all...

I wish I'd noticed this before I wasted my time 💀

@exussum12
Copy link
Contributor Author

Ah sorry :( I was looking to add upstream and the PR seemed good. I didn't spot it was rejected either :(

@Gadgetoid
Copy link
Member

S'okay, I've got an open sync branch for when we get some crop functionality 😆

Didn't realise until I'd updated the bindings, tried to compile, and thought "wut!? Y Error!?"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants