Feature/240x135-lcd #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backward compatibility for square aspect ratio is maintained.
|
Thank you- I'm completely replacing the numpy RGB888 to RGB5565 code with: 568e04c My attempts to get a 240x135 pixel display up and running were... unsuccessful (with/without this change)... if you get a moment could you confirm it still works with this change? |
|
@Gadgetoid there seems to be no problem with 568e04c! |
|
Whew, thank you for testing and doubly for doing it so quickly too!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support to the provided examples for 240x135 resolution LCD (successfully tested on Pimoroni Pico Display Pack).
One key change has been made to the library itself here, that would otherwise fail for non square displays.