Skip to content

auto-completion file for the FISH shell #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 25, 2021
Merged

auto-completion file for the FISH shell #83

merged 3 commits into from
Mar 25, 2021

Conversation

eshapard
Copy link
Contributor

@eshapard eshapard commented Mar 20, 2021

Checklist

  • I have made a change to this repository, be it functionality, testing, documentation, spelling, or grammar.
  • I updated my branch with the master branch.
  • I have added the necessary testing to prove my fix is effective/my feature works (or I did not modify functionality).
  • I have added necessary documentation about the functionality in an appropriate .md file.
  • I have appropriately commented any code I have modified

Short description of what this PR does:

Adds an auto-completion file for the Fish shell.

@pimterry
Copy link
Owner

I'm not a fish user, but at a glance the code looks reasonable to me. Could you add some installation instructions in the readme too, with the other autocomplete docs? Here: https://github.com/pimterry/notes#installing-auto-completion

Added install notes for Fish shell auto-completion script
Copy link
Contributor Author

@eshapard eshapard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added instructions for Fish autocompletion file in README.md

@pimterry pimterry merged commit 3ef4d18 into pimterry:master Mar 25, 2021
@pimterry
Copy link
Owner

Great stuff, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants