Single port graceful shutdown 2 #113
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up on #101 which fixes the real problem:
Shutdown
does not work in single-port mode. It is deliberate so we don't drop in-progress transfers on the floor when shutdown is called.Still, we want
Shutdown
to work. This PR does two things:TestShutdownDuringTransfer
test that starts a transfer and then callsShutdown
. It expects that shutdown succeeds and ongoing transfer still succeed too. Of course, it is opinionated question if we actually want graceful shutdown in the first place, and it probably would be good to have aShutdown
variant which does drops all on the floor and stops. But that is for later.single_port.go
so that the behavior of single-port server matches the behavior of the regular server. OnShutdown
, stop accepting new transfer, but finish the existing ones, then exit.