-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update changelog and bump version to 3.3.2 #378
Conversation
It works for me, both doing a |
@blag - you need to commit and push the migration file |
Isn't the migration file in question already in the I'm getting the feeling that I'm missing something obvious that I need to fix before merging this... |
No - thats just me with amnesia 😵💫 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Is it normal that 3.3.2 is't released yet? |
@carchan1 Thank you for your interest in the 3.3.2 release. Yes it is normal. We are still within the timeline I mentioned here, and while reminders are nice once in awhile, they aren't positively productive when we are still within the communicated timeline. Also, don't be surprised if the expected timeline slips a bit. This is an open source project, one of a few that I maintain, and I am not paid for any of the work I do. I am pulled in a thousand different directions at once and this project isn't necessarily my highest priority from moment to moment. If you would like to reduce the burden on us maintainers and make our jobs easier, it would be more helpful to contribute PRs for the fixes and improvements you wish to see, triage issues, and review the PRs of others. Or consider applying to become a maintainer yourself, which would allow you to independently commit changes and publish releases on your own. |
We will inlcude an auto release mechanism as part of a github workflow soon that will lighten the burden of release maintenance but for now as @blag points out, it is not necessarily any of the current maintainers highest priority. |
Attempting to release now. If it goes well it should be out in a few minutes. If it doesn't go well it will need to wait until at least Monday. |
The release process went well. Thank you for your patience. The v3.3.2 release is now available on PyPI and GitHub. In general, I'm not a huge fan of automated releases but if it eases the burden on maintainers then I'm willing to accept it. PRs implementing that are welcome and I'm happy to engage with testing that. |
Changes proposed in this PR:
I'd appreciate it if somebody independently verified that
account/migrations/0006_alter_signupcode_max_uses.py
andaccount/migrations/0007_alter_emailconfirmation_sent.py
are both included in the built distribution (both wheel and sdist).To check:
cd
to it.dist/
and untar the tarball indist/
and check their contents include the mentioned migrations files.Tips for an ideal PR
setup.py
(Pinax uses SemVer)Change Log
has been updatedAUTHORS
file