Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog and bump version to 3.3.2 #378

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Conversation

blag
Copy link
Collaborator

@blag blag commented Sep 28, 2023

Changes proposed in this PR:

  • Update changelog
  • Bump version to 3.3.2

I'd appreciate it if somebody independently verified that account/migrations/0006_alter_signupcode_max_uses.py and account/migrations/0007_alter_emailconfirmation_sent.py are both included in the built distribution (both wheel and sdist).

To check:

  1. Clone this repo and cd to it.
  2. Create and activate a virtualenv.
  3. python3 -m pip install --upgrade build
    python3 -m build
  4. Unzip the .whl in dist/ and untar the tarball in dist/ and check their contents include the mentioned migrations files.

Tips for an ideal PR

@carchan1
Copy link

It works for me, both doing a pip install on the .whl and unzipping the .tar

@uhurusurfa
Copy link
Collaborator

@blag - you need to commit and push the migration file

@blag
Copy link
Collaborator Author

blag commented Sep 29, 2023

Isn't the migration file in question already in the master branch?

https://github.com/pinax/django-user-accounts/blob/master/account/migrations/0006_alter_signupcode_max_uses.py

I'm getting the feeling that I'm missing something obvious that I need to fix before merging this...

@uhurusurfa
Copy link
Collaborator

No - thats just me with amnesia 😵‍💫
All good

Copy link
Collaborator

@uhurusurfa uhurusurfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@uhurusurfa uhurusurfa merged commit 4722d7f into master Sep 29, 2023
9 checks passed
@carchan1
Copy link

carchan1 commented Oct 5, 2023

Is it normal that 3.3.2 is't released yet?

@blag
Copy link
Collaborator Author

blag commented Oct 5, 2023

@carchan1 Thank you for your interest in the 3.3.2 release. Yes it is normal. We are still within the timeline I mentioned here, and while reminders are nice once in awhile, they aren't positively productive when we are still within the communicated timeline. Also, don't be surprised if the expected timeline slips a bit.

This is an open source project, one of a few that I maintain, and I am not paid for any of the work I do. I am pulled in a thousand different directions at once and this project isn't necessarily my highest priority from moment to moment. If you would like to reduce the burden on us maintainers and make our jobs easier, it would be more helpful to contribute PRs for the fixes and improvements you wish to see, triage issues, and review the PRs of others. Or consider applying to become a maintainer yourself, which would allow you to independently commit changes and publish releases on your own.

@blag blag deleted the version-3.3.2 branch October 5, 2023 19:12
@uhurusurfa
Copy link
Collaborator

We will inlcude an auto release mechanism as part of a github workflow soon that will lighten the burden of release maintenance but for now as @blag points out, it is not necessarily any of the current maintainers highest priority.

@blag
Copy link
Collaborator Author

blag commented Oct 6, 2023

Attempting to release now. If it goes well it should be out in a few minutes. If it doesn't go well it will need to wait until at least Monday.

@blag
Copy link
Collaborator Author

blag commented Oct 6, 2023

The release process went well. Thank you for your patience.

The v3.3.2 release is now available on PyPI and GitHub.

In general, I'm not a huge fan of automated releases but if it eases the burden on maintainers then I'm willing to accept it. PRs implementing that are welcome and I'm happy to engage with testing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants