Skip to content

Update README and examples to reflect v1 changes #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 12, 2024
Merged

Conversation

aulorbe
Copy link
Contributor

@aulorbe aulorbe commented Apr 10, 2024

Problem

We are close to launching v1! With it, our README needs a facelift. Here is that facelift 💅.
We have also updated the SDK version, user-agent string, and the examples package.

Asana tix:

Solution

Update README, user-agent string, and examples for v1 java SDK. We have currently removed the UpsertsAndQueriesConcurrentExample example but in upcoming PR's, we will like to add it back.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

@rohanshah18 rohanshah18 changed the title Update README to reflect v1 changes Update README and examples to reflect v1 changes Apr 12, 2024
Copy link
Contributor

@austin-denoble austin-denoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, I'm not sure if the version comment in the CHANGELOG file needs to be updated to v1.0.0 though.

@rohanshah18 rohanshah18 merged commit e259bd4 into main Apr 12, 2024
@rohanshah18 rohanshah18 deleted the rshah/updateREADME branch April 12, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants