-
Notifications
You must be signed in to change notification settings - Fork 13
Update README and examples to reflect v1 changes #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssmith-pc
reviewed
Apr 11, 2024
ssmith-pc
reviewed
Apr 11, 2024
rohanshah18
reviewed
Apr 12, 2024
austin-denoble
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, I'm not sure if the version comment in the CHANGELOG
file needs to be updated to v1.0.0
though.
examples/java-basic-mvn/src/main/java/pineconeexamples/MinimalUpsertAndQueryExample.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We are close to launching v1! With it, our README needs a facelift. Here is that facelift 💅.
We have also updated the SDK version, user-agent string, and the examples package.
Asana tix:
Solution
Update README, user-agent string, and examples for v1 java SDK. We have currently removed the UpsertsAndQueriesConcurrentExample example but in upcoming PR's, we will like to add it back.
Type of Change